Save xpf data in png chunk #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice improvement, thanks! Please show an error message if the loaded image does not contain any xpf data. Is the hidden temp file working also on non-Unix systems? |
|
Yes this works in non unix systems as well.
|
|
It seems to me that the error message is shown for a very short time. Can this be improved? |
|
This is being handled by xaos timer library. Currently they are visible for same time as other error messages. |
|
OK, great. Can it be risky to increase EXPIRETIME? Does it have a negative effect somewhere else? |
|
Setting it from 4000000 to 5000000 looks better without negative effects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type : Enhancement
Fixes #128
Changes:
Added option to 'Open Image' under File menu.T
This option allows to save & open PNG without XPF data.